-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3:bump aws-sdk-go-v2/config for aws service endpoint env vars #132
Conversation
Signed-off-by: matthewhudsonedb <[email protected]>
Signed-off-by: matthewhudsonedb <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good. Can you please fix conflicts?
Signed-off-by: matthewhudsonedb <[email protected]>
@yeya24 conflicts have been fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: matthewhudsonedb <[email protected]>
@JoaoBraveCoding @yeya24 another conflict for release notes appeared which I've also fixed. |
Signed-off-by: matthewhudsonedb <[email protected]>
Changes
s3:bump aws-sdk-go-v2/config for aws service endpoint env vars
Verification