Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3:bump aws-sdk-go-v2/config for aws service endpoint env vars #132

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

matthewhudsonedb
Copy link
Contributor

@matthewhudsonedb matthewhudsonedb commented Aug 26, 2024

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

s3:bump aws-sdk-go-v2/config for aws service endpoint env vars

Verification

Signed-off-by: matthewhudsonedb <[email protected]>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. Can you please fix conflicts?

Signed-off-by: matthewhudsonedb <[email protected]>
@matthewhudsonedb
Copy link
Contributor Author

@yeya24 conflicts have been fixed

Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: matthewhudsonedb <[email protected]>
@matthewhudsonedb
Copy link
Contributor Author

@JoaoBraveCoding @yeya24 another conflict for release notes appeared which I've also fixed.

Signed-off-by: matthewhudsonedb <[email protected]>
@JoaoBraveCoding JoaoBraveCoding merged commit 063ea38 into thanos-io:main Dec 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants