Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web): improve the clarity of the torrentstotal semantics #540

Closed
wants to merge 1 commit into from
Closed

refactor(web): improve the clarity of the torrentstotal semantics #540

wants to merge 1 commit into from

Conversation

lazyoop
Copy link

@lazyoop lazyoop commented Dec 24, 2024

No description provided.

@tgragnato tgragnato self-requested a review December 25, 2024 20:40
@tgragnato tgragnato added refactoring Simplify, eliminate, improve go Pull requests that update Go code labels Dec 25, 2024
tgragnato
tgragnato requested changes Dec 25, 2024
View reviewed changes
Copy link
Owner

@tgragnato tgragnato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't want to break the semantics and backward compatibility of this API endpoint. Can you introduce the new semantics on a new endpoint without changing the behavior of the old one?

@lazyoop
Copy link
Author

lazyoop commented Dec 26, 2024

Implementing backward compatibility on the existing API endpoint seems feasible to me.
I will make the changes and submit the PR as soon as possible.

@lazyoop lazyoop mentioned this pull request Dec 27, 2024
Merged
@lazyoop lazyoop closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgragnato tgragnato tgragnato requested changes

Assignees

@lazyoop lazyoop

Labels
go Pull requests that update Go code refactoring Simplify, eliminate, improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazyoop @tgragnato