Add decomposition for Grid_Sample and Floor op #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meenakshiramanathan1
force-pushed
the
mramanathan/grid_sample_tvm
branch
6 times, most recently
from
ffbf66b to
ea03475
Compare
meenakshiramanathan1
requested review from
nvukobratTT,
pilkicTT and
dgolubovicTT
nvukobratTT
requested changes
Dec 30, 2024
|
|
||
| # Compute integer pixel indices for bilinear interpolation | ||
| if mode == 'bilinear': | ||
| x0 = tvm.relay.floor(x).astype("int32") |
There was a problem hiding this comment.
Do we need to do a type cast?
There was a problem hiding this comment.
Yes, if it's not typecasted we are ending up with dtype mismatch later.
There was a problem hiding this comment.
I see. Let's print out a warning as well.
meenakshiramanathan1
force-pushed
the
mramanathan/grid_sample_tvm
branch
3 times, most recently
from
863f508 to
7cec18c
Compare
meenakshiramanathan1
force-pushed
the
mramanathan/grid_sample_tvm
branch
from
7cec18c to
8aed232
Compare
nvukobratTT
approved these changes
Jan 3, 2025
|
|
||
| # Compute integer pixel indices for bilinear interpolation | ||
| if mode == 'bilinear': | ||
| x0 = tvm.relay.floor(x).astype("int32") |
There was a problem hiding this comment.
I see. Let's print out a warning as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decomposition for torch.grid_sample and torch.floor op has been added.
Grid Sample op decomposition has been adapted from bilinear grid sample from here.
Currently this decomposition supports bilinear interpolation mode with 4d input shapes only, nearest interpolation mode and 5d inputs support will be added later.
The change in DecomposeMultiDimSqueeze callback has been added to handle this failure when squeeze_() was used.
TypeError: 'NoneType' object is not iterableSo in that cases, all dimensions with value 1 will be squeezed.