Add TOSA to TTIR conversion for reshape #1475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgligorijevicTT
force-pushed
the
sgligorijevic/tosa-add-reshape
branch
from
4d6355f to
7a0e745
Compare
sgligorijevicTT
requested review from
ajakovljevicTT,
mrakitaTT and
kmitrovicTT
kmitrovicTT
approved these changes
Dec 4, 2024
Comment on lines
+91
to
+110
| matchAndRewrite(tosa::ReshapeOp srcOp, Adaptor adaptor, | ||
| ConversionPatternRewriter &rewriter) const override { | ||
| auto outputType = mlir::cast<RankedTensorType>(srcOp.getResult().getType()); | ||
| mlir::OpBuilder builder(getContext()); | ||
| mlir::DenseI64ArrayAttr src_shape_attr = adaptor.getNewShapeAttr(); | ||
| SmallVector<Attribute> dims; | ||
| for (int64_t dim : src_shape_attr.asArrayRef()) { | ||
| dims.push_back(builder.getI32IntegerAttr(dim)); | ||
| } | ||
| auto dst_shape_attr = rewriter.getArrayAttr(dims); | ||
|
|
||
| auto outputTensor = rewriter.create<tensor::EmptyOp>( | ||
| srcOp.getLoc(), outputType.getShape(), outputType.getElementType()); | ||
| rewriter.replaceOpWithNewOp<mlir::tt::ttir::ReshapeOp>( | ||
| srcOp, outputType, adaptor.getInput1(), outputTensor, dst_shape_attr, | ||
| rewriter.getArrayAttr( | ||
| SmallVector<Attribute>(adaptor.getOperands().size() + 1, | ||
| rewriter.getAttr<OperandConstraintAttr>( | ||
| OperandConstraint::AnyDeviceTile)))); | ||
| return success(); |
Comment on lines
+95
to
+100
| mlir::DenseI64ArrayAttr src_shape_attr = adaptor.getNewShapeAttr(); | ||
| SmallVector<Attribute> dims; | ||
| for (int64_t dim : src_shape_attr.asArrayRef()) { | ||
| dims.push_back(builder.getI32IntegerAttr(dim)); | ||
| } | ||
| auto dst_shape_attr = rewriter.getArrayAttr(dims); |
There was a problem hiding this comment.
You can simplify this a bit
std::vector<int32_t> new_shape_i32;
for (int64_t dim : outputType.getShape()) {
new_shape_i32.push_back(static_cast<int32_t>(dim));
}
ArrayAttr new_shape_attr = rewriter.getI32ArrayAttr(new_shape_i32);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ReshapeOp.
closes #1474