Uplift 2024-06-27 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vmilosevic
commented
Jun 27, 2024
vmilosevic
commented
- Adding the latest PyBuda code changes
- Adding support for wormhole_b0
- Adding wormhole_b0 build action
(cherry picked from commit 0cd7afda10dd32716637dccc58e679e4238491f6)
(cherry picked from commit 890b40a17ed4785a0e2cbbc7815d9be135e5fca8)
(cherry picked from commit 74c69ce3de4da34c868f0fbac6857e7b9ddc4282)
(cherry picked from commit 75eb3bc03afec42b50cdc76af8da5ce5c04945a3)
(cherry picked from commit 1ca541bcea483bd1708353f9de25412a2c4c1646)
(cherry picked from commit 8fb00f9b9eed67f073162677f9b8ef8fa2dc6a28)
(cherry picked from commit 159ce461a7449fe37454ca9b72fa2651c925b83c)
…khole" due to..." with the fix (cherry picked from commit 5a0e1822f7f639b302c94a4ff81972aa75e9957f)
(cherry picked from commit 6c995433b4b4164efa3d3fc4b6aa8a0db07e5107)
(cherry picked from commit 123f62088e5b64f4c457352ebc4ffdc37f3b08cb)
(cherry picked from commit 0e5401efc45603a3c03022bddb1c0c48f02c69d3)
… failures. (cherry picked from commit 12352f59ab050fac86563829d79aea5f3ea7f6ef)
(cherry picked from commit 9fd065c70bdaed2900dc3d3e0f3d74754bb383b3)
(cherry picked from commit 711927afad3e6d94d3c8cccf61344e03f475a0f1)
(cherry picked from commit a15c8be20a843abed134cf458ef4dcc6bb67a0ce)
…h. [perf_wh] (cherry picked from commit 0cdf10fd5741defa99be8fda8451f29435a6b4c1)
(cherry picked from commit b790f0886381df35e2452b98b4008f5b904083c1)
(cherry picked from commit 3f9e39aa062043b5af15122fc335d13f6322eb4e)
(cherry picked from commit b65ba79b0b09b86ef88d108b12b10aa9ab8ab0d0)
(cherry picked from commit a3738fa2e5ddd11bd05cd536810747d2899fed13)
(cherry picked from commit 38f08c90f02ee3db9438d0903d5260ea54fa4460)
The case when a queue instruction is merged with a NOP instruction was not handled properly. This case can be hit when GS cuts the graph somewhere on a fork-join path, so we need to buffer the fork-join with queues. Let's say that the previous instruction added NOP buffer_0_1_2 between nodes A and B. In the next iteration of epoch balancing, GS cuts the graph somewhere on that fork-join and we need to add a buffering queue on the path between A and B. The new instruction will have nodes A and buffer_0_1_2 as src/dest pair. So, to properly merge these instructions, we need to create a new queue instruction with nodes A and B as src/dest pair, and use it as a replacement for the old (NOP) instruction. (cherry picked from commit bfd97cdffd9c5d10f2327e230baeaaaea577f0be)
Yolov5 tests were failing due to an issue with merging of queue instructions in fork-join buffering logic for Ribbon. Removing legacy ribbon flag now that the issue is fixed. (cherry picked from commit dae7cd158f150b634ae491e80a6877abebb3cf9b)
(cherry picked from commit 6e9a3669d96feb6b6b9709b176f6773bf39cc1cd)
(cherry picked from commit 8a4121eb946d9929d9085d99f7412e950103fa1b)
vmilosevic
force-pushed
the
vmilosevic/uplift-2024-06-27
branch
2 times, most recently
from
8de55b4 to
8364a9f
Compare
vmilosevic
force-pushed
the
vmilosevic/uplift-2024-06-27
branch
from
8364a9f to
8772356
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.