Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blocked Reason, Link and Link Namespace to Callback UI #2476

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

Alex-Tideman
Copy link
Contributor

@Alex-Tideman Alex-Tideman commented Dec 12, 2024

Description & motivation 💭

Added new Blocked Reason on callback, show in UI.
Also added Link and Link Namespace to the callback UI to replace URL.

Added Link Namespace to expanded event summary details to easily jump to the namespace of the link.

Screenshots (if applicable) 📸

Screenshot 2024-12-12 at 1 44 00 PM Screenshot 2024-12-12 at 1 44 11 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 7:56pm

@Alex-Tideman Alex-Tideman changed the title Add Blocked Reason to callback and include link to link namespace Add Blocked Reason, Link and Link Namespace to Callback UI Dec 12, 2024
@Alex-Tideman Alex-Tideman merged commit 22b37ea into main Dec 13, 2024
14 checks passed
@Alex-Tideman Alex-Tideman deleted the blocked-reason branch December 13, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants