Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline styles for CodeBlock component #2444

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

laurakwhit
Copy link
Contributor

@laurakwhit laurakwhit commented Nov 27, 2024

Description & motivation 💭

  • Fixes inline variant of the CodeBlock component
  • Uses css variables for colors instead of two separately defined HighlightStyles

Screenshots (if applicable) 📸

Before After
Screenshot 2024-11-26 at 5 23 26 PM Screenshot 2024-11-26 at 5 24 10 PM
Screenshot 2024-11-26 at 5 23 41 PM Screenshot 2024-11-26 at 5 23 55 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-2636

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested review from rossedfort and a team as code owners November 27, 2024 00:26
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 4:37pm

@laurakwhit laurakwhit merged commit 96756db into main Nov 27, 2024
14 checks passed
@laurakwhit laurakwhit deleted the fix-inline-codeblock branch November 27, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants