Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IS NULL and IS NOT NULL filter search #2298

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

laurakwhit
Copy link
Contributor

Description & motivation 💭

Adds support for is null and is not null queries to filter search.

Screenshots (if applicable) 📸

Is null Is not null
Screenshot 2024-08-30 at 10 50 48 AM Screenshot 2024-08-30 at 10 50 58 AM
Text field Datetime field Boolean field Number field
Screenshot 2024-08-30 at 10 49 40 AM Screenshot 2024-08-30 at 10 49 50 AM Screenshot 2024-08-30 at 10 50 10 AM Screenshot 2024-08-30 at 10 50 22 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

  • Verify Is null and Is not null show up for the following attributes

    • Int or Double
    • Text or Keyword
    • Boolean
    • Datetime
  • and the filter works as expected

    • query is applied correctly in the url
    • query shows up correctly in the search input
    • refreshing the page the query shows up and is applied correctly
    • removing and adding multiple filters works as expected
  • Verify when selecting an existing filter

    • the correct conditional and value are shown
    • changing the conditional and/or value works as expected

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-2384

Docs

Any docs updates needed?

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 5:33pm

Copy link
Contributor

@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, have not done any testing yet.

@laurakwhit laurakwhit merged commit 8f10db3 into main Sep 5, 2024
14 checks passed
@laurakwhit laurakwhit deleted the DT-2384-support-empty-non-empty-filter-search branch September 5, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants