Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlapping workflow details text #2162

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

laurakwhit
Copy link
Contributor

Description & motivation 💭

Fixes styling of WorkflowDetail components to ensure truncation and no overlapping text.

Screenshots (if applicable) 📸

Before After
Screenshot 2024-06-17 at 12 11 23 PM Screenshot 2024-06-17 at 12 58 01 PM
Screenshot 2024-06-17 at 12 11 40 PM Screenshot 2024-06-17 at 12 57 00 PM
Screenshot 2024-06-17 at 1 12 17 PM Screenshot 2024-06-17 at 1 27 40 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-2232

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested a review from rossedfort as a code owner June 17, 2024 19:35
Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 7:35pm

Copy link
Contributor

@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, out of curiosity, why remove the style block and define the classes inline? Was truncate not working when defined in the style block?

@laurakwhit
Copy link
Contributor Author

why remove the style block and define the classes inline? Was truncate not working when defined in the style block?

@rossedfort Yeah there's some wonkiness with postcss when being used in a class that's passed to a component that also has postcss 😅 I think we might want to think about moving away from postcss in Holocene components at least...

@laurakwhit laurakwhit merged commit 7d4f82e into main Jun 17, 2024
11 checks passed
@laurakwhit laurakwhit deleted the DT-2232-fix-overlapping-workflow-details-text branch June 17, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants