Skip to content

Commit

Permalink
Update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex-Tideman committed Jul 10, 2024
1 parent a458560 commit ba13245
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
6 changes: 5 additions & 1 deletion src/lib/holocene/navigation/navigation-item.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
$: target = external ? '_blank' : '';
</script>

<div role="listitem" data-testid={$$props['data-testid']} class="relative">
<div
role="listitem"
data-testid={$$props?.['data-testid'] || `${icon}-button`}
class="relative"
>
<a
href={link}
{rel}
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/data-encoder.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ test.describe('Data Encoder without Configuration Settings', () => {

await page
.locator('label')
.filter({ hasText: 'Pass the user access token with your endpoint.' })
.filter({ hasText: 'Pass the user access token with your endpoint' })
.click();

await expect(page.locator('.error-msg')).toHaveText(
Expand Down Expand Up @@ -167,7 +167,7 @@ test.describe('Data Encoder without Configuration Settings', () => {

await page
.locator('label')
.filter({ hasText: 'Include cross-origin credentials.' })
.filter({ hasText: 'Include cross-origin credentials' })
.click();

await dataEncoderConfirmButton.click();
Expand Down
3 changes: 1 addition & 2 deletions tests/integration/workflow-navigation.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,13 @@ test('Top Navigation current namespace is present and has other namespaces to se
).toBeHidden();
});

test('Top Navigation current namespace is not present on non-namespace specific pages', async ({
test('Top Navigation current namespace is present on non-namespace specific pages', async ({
page,
}) => {
const switcher = page.getByTestId('namespace-switcher');

await expect(switcher).toBeVisible();
await page.getByRole('link', { name: 'Namespaces' }).click();
await expect(switcher).toBeHidden();
await page.getByRole('link', { name: 'Workflows' }).first().click();
await expect(switcher).toBeVisible();
});

0 comments on commit ba13245

Please sign in to comment.