Fix bug related to non unique references on genRefs functions

telosnetwork · May 14, 2024 · f1d0eec · f1d0eec
1 parent 36a5e06
commit f1d0eec
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@guilledk/arrowbatch-nodejs",
-  "version": "1.0.0-rc8",
+  "version": "1.0.0-rc9",
   "description": "Arrow Batch Storage protocol",
   "main": "./build/index.js",
   "type": "module",

diff --git a/src/reader/index.ts b/src/reader/index.ts
@@ -327,6 +327,19 @@ export class ArrowBatchReader extends ArrowBatchContext {
         auxiliary: boolean = false
     ): RowWithRefs {
         const references  = this.refMappings.get(tableName);
+        const processedRefs = new Set();
+        const uniqueRefs = [];
+        Object.values(references).forEach(val => {
+            const parentInfo = {
+                index: val.parentIndex,
+                mapping: val.parentMapping
+            };
+            if (!processedRefs.has(JSON.stringify(parentInfo))) {
+                processedRefs.add(JSON.stringify(parentInfo));
+                uniqueRefs.push(val);
+            }
+        });
+
         const childRowMap = new Map<string, RowWithRefs[]>();
         for (const [refName, reference] of Object.entries(references)) {
             const refs = this.getRowsFromBufferByRef(
@@ -356,8 +369,21 @@ export class ArrowBatchReader extends ArrowBatchContext {
         tables: ArrowCachedTables
     ): RowWithRefs {
         const references  = this.refMappings.get(tableName);
+        const processedRefs = new Set();
+        const uniqueRefs = [];
+        Object.values(references).forEach(val => {
+            const parentInfo = {
+                index: val.parentIndex,
+                mapping: val.parentMapping
+            };
+            if (!processedRefs.has(JSON.stringify(parentInfo))) {
+                processedRefs.add(JSON.stringify(parentInfo));
+                uniqueRefs.push(val);
+            }
+        });
+
         const childRowMap = new Map<string, RowWithRefs[]>();
-        for (const [refName, reference] of Object.entries(references)) {
+        for (const reference of uniqueRefs) {
             const refs = this.getRowsFromTablesByRef(
                 tableName, reference.parentMapping, row[reference.parentIndex], tables);