Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix role in openshift and include upgrade status #1750

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

jkandasa
Copy link
Member

Changes

Upgrade mechanism added in #1675 and in this PR fixes the following issues,

Fixes:

  • allows operator to patch/update resolutionrequests.resolution.tekton.dev in openshift
  • included upgrade status into TektonConfig CR under status

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@jkandasa jkandasa added the kind/bug Categorizes issue or PR as related to a bug. label Sep 27, 2023
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 27, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 27, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_lifecycle.go 75.9% 65.3% -10.6
pkg/reconciler/shared/tektonconfig/upgrade/upgrade.go 86.0% 84.4% -1.6

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@jkandasa
Copy link
Member Author

/cherry-pick @release-v0.68.x

@tekton-robot
Copy link
Contributor

@jkandasa: once the present PR merges, I will cherry-pick it on top of @release-v0.68.x in a new PR and assign it to you.

In response to this:

/cherry-pick @release-v0.68.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@tekton-robot tekton-robot merged commit f7fb36f into tektoncd:main Sep 27, 2023
2 checks passed
@tekton-robot
Copy link
Contributor

@jkandasa: cannot checkout @release-v0.68.x: error checking out @release-v0.68.x: exit status 1. output: error: pathspec '@release-v0.68.x' did not match any file(s) known to git

In response to this:

/cherry-pick @release-v0.68.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkandasa jkandasa deleted the fix_upgrade_permission branch September 27, 2023 07:58
@jkandasa
Copy link
Member Author

/cherry-pick release-v0.68.x

@tekton-robot
Copy link
Contributor

@jkandasa: new pull request created: #1751

In response to this:

/cherry-pick release-v0.68.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants