-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify connection establishment #1663
Merged
arthurschreiber
merged 14 commits into
master
from
arthur/refactor-states-for-connecting
Sep 15, 2024
Merged
refactor: simplify connection establishment #1663
arthurschreiber
merged 14 commits into
master
from
arthur/refactor-states-for-connecting
Sep 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1663 +/- ##
==========================================
+ Coverage 85.47% 86.09% +0.62%
==========================================
Files 90 90
Lines 4859 4853 -6
Branches 924 920 -4
==========================================
+ Hits 4153 4178 +25
+ Misses 702 670 -32
- Partials 4 5 +1 ☔ View full report in Codecov by Sentry. |
arthurschreiber
force-pushed
the
arthur/refactor-states-for-connecting
branch
from
September 12, 2024 15:54
7d6d9a3
to
2e4cf8b
Compare
arthurschreiber
force-pushed
the
arthur/refactor-states-for-connecting
branch
from
September 15, 2024 08:57
6c1232c
to
96a9ac4
Compare
arthurschreiber
force-pushed
the
arthur/refactor-states-for-connecting
branch
from
September 15, 2024 09:21
96a9ac4
to
8fc86dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.socketError
, throw errors and have them handled centrally ininitialiseConnection
.async
/await
wherever possible.