Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: cleanup AbortSignal handling #1654

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

arthurschreiber
Copy link
Collaborator

@arthurschreiber arthurschreiber commented Aug 18, 2024

BREAKING CHANGE: tedious now requires Node.js version 18.17 or later.

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.13%. Comparing base (5463652) to head (b8b3da8).
Report is 1 commits behind head on master.

Files Patch % Lines
src/sender.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1654      +/-   ##
==========================================
+ Coverage   78.25%   79.13%   +0.88%     
==========================================
  Files          93       90       -3     
  Lines        4879     4855      -24     
  Branches      937      929       -8     
==========================================
+ Hits         3818     3842      +24     
+ Misses        762      710      -52     
- Partials      299      303       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurschreiber
Copy link
Collaborator Author

arthurschreiber commented Aug 21, 2024

One note from discussing this with @MichaelSun90 - this probably requires bumping the engine version to >= 18.17, as AbortSignal.any was added in 18.17.0.

EDIT: And this makes it a breaking change, so we need to thing about that too.

@arthurschreiber arthurschreiber changed the title refactor: cleanup AbortSignal handling refactor!: cleanup AbortSignal handling Aug 22, 2024
@arthurschreiber arthurschreiber merged commit 669ab44 into master Aug 22, 2024
25 of 27 checks passed
Copy link

🎉 This PR is included in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant