feat: list/rank soil inconsistency workaround #2569
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrouxm
changed the title
1 task
shrouxm
changed the title
shrouxm
force-pushed
the
feat/list-rank-soil-inconsistency-workaround
branch
from
5c80e5a to
bcdc04b
Compare
shrouxm
force-pushed
the
feat/list-rank-soil-inconsistency-workaround
branch
from
bcdc04b to
44ced8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the
fetchLocationBasedSoilMatchesredux action to secretly call thefetchDataBasedSoilMatchesendpoint with an empty set of data. See discussion on techmatters/soil-id-algorithm#126 for why this is desirable behaviorally. This is in draft because it puts the codebase in a kinda hacky state where the method names aren't really honest anymore, but I wanted to record my progress before I take time off.Checklist
Related Issues
Related to techmatters/soil-id-algorithm#126. Depends on techmatters/terraso-client-shared#1112.
Verification steps
There should be no difference in the soil ID results now before or after creating a site.