fix: GraphQL Group filters using deleted associated objects #101
+170
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a specific case where using Django built-in lookups for relationships doesn't work properly with the soft delete solution we implemented with `django-safedelete`. According to the library maintainers, it's a known limitation[1]. To work around this limitation, a customized filter set were created for Group schema on GraphQL. This custom filter set implements the adjustments expected to ignore soft deleted objects when filtering by relationships (joins). [1] - makinacorpus/django-safedelete#158
caiocarrara
force-pushed
the
fix/groups-filters-with-deleted-objs
branch
from
4909756 to
701f3aa
Compare
paulschreiber
approved these changes
Jan 25, 2022
This was referenced Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a specific case where using Django built-in lookups for
relationships don't work properly with the soft delete solution we
implemented with
django-safedelete. According to the librarymaintainers, it's a known limitation[1].
To work around this limitation, a customized filter set were created for
Group schema on GraphQL. This custom filter set implements the
adjustments expected to ignore soft deleted objects when filtering by
relationships (joins).
[1] - makinacorpus/django-safedelete#158