This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Update dependencies and applications #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No super, to se mi hodí, zrovna to chci použít :-D |
jakubboucek
suggested changes
Feb 15, 2022
functions/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| *.local | |||
There was a problem hiding this comment.
Duplicated with .gitignote rules at root folder.
functions/src/index.ts
Outdated
Comment on lines
7
to
9
| import dotenv from "dotenv" | ||
|
|
||
| dotenv.config() |
There was a problem hiding this comment.
Did you have any .env config required for production? Pls, put here any sample file and add installation instructions to README.md file.
There was a problem hiding this comment.
Maybe it's whole unnecessary, because Firebase is using dotfile internally: https://firebase.google.com/docs/functions/config-env#env-variables
public/admin/index.html
Outdated
| <script src="firebaseConfig.js"></script> | ||
| <script> | ||
| // Initialize Firebase | ||
| firebase.initializeApp(firebaseConfig); | ||
| firebase.auth().useEmulator("http://localhost:9099"); |
There was a problem hiding this comment.
ALERT ALERT, unwanted dev emulator - can cause to broke production!
There was a problem hiding this comment.
oh, my bad, forgot to remove it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.