Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ssh2 library and fixed sftp write command. #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated ssh2 library and fixed sftp write command. #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e404b9
Updated ssh2 library to latest and fixed file write hanging.
akotulu Feb 2, 2024
cd76f7a
Fixed invalid event for writing with sftp.
akotulu Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,21 +173,22 @@ class GulpSSH extends EventEmitter {
const write = sftp.createWriteStream(filePath, options)

write
.on('open', function() {
if (file.isStream()) file.contents.pipe(write)
else if (file.isBuffer()) write.end(file.contents)
else {
err = new PluginError(packageName, 'file error!')
write.end()
}
})
.on('error', function (error) {
err = error
})
.on('finish', function () {
.on('close', function () {
sftp.end()
if (err) callback(err)
else callback(null, file)
})

if (file.isStream()) file.contents.pipe(write)
else if (file.isBuffer()) write.end(file.contents)
else {
err = new PluginError(packageName, 'file error!')
write.end()
}
})
})
}, function (callback) {
Expand Down Expand Up @@ -346,8 +347,8 @@ class GulpSSH extends EventEmitter {

let lastCommand
commands.forEach(function (command) {
if (command[command.length - 1] !== '\n') command += '\n'
log(packageName + ' :: shell :: ' + command)
if (command[command.length - 1] !== '\n') command += '\n'
stream.write(command)
lastCommand = command
})
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gulp-ssh",
"version": "0.7.1",
"version": "0.7.2",
"description": "SSH and SFTP tasks for gulp",
"license": "MIT",
"author": {
Expand Down Expand Up @@ -32,7 +32,7 @@
"ansicolors": "^0.3.2",
"fancy-log": "^1.3.2",
"plugin-error": "^1.0.1",
"ssh2": "~0.5.5",
"ssh2": "^1.14.0",
"through2": "^2.0.3",
"vinyl": "^2.1.0"
},
Expand Down