chore: constants fix #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JetBluefan1
commented
Nov 18, 2024
•
JetBluefan1
commented
- closes chore: add units to constants #12
minhd-vu
reviewed
Nov 18, 2024
minhd-vu
reviewed
Nov 18, 2024
minhd-vu
reviewed
Nov 18, 2024
minhd-vu
reviewed
Nov 18, 2024
src/main/java/frc/robot/commands/drivebase/AbsoluteFieldDrive.java
Outdated
Show resolved
Hide resolved
minhd-vu
reviewed
Nov 18, 2024
Lubcas
added a commit
that referenced
this pull request
Dec 4, 2024
* chore: set line endings * chore: constants fix (#16) * chore: constants fix * Update src/main/java/frc/robot/Constants.java * Update src/main/java/frc/robot/Constants.java * Update src/main/java/frc/robot/Constants.java * fix: chassis matter * fix: loop overrun warning (#17) * fix: loop overrun warning * fix: formatting * feat: intake (#15) * feat: created intake subsystem * feat: added intake commands * fix: updated intake to use units/inline commands * fix: removed motor inversion, removed units for speed * fix: formatting * fix: fixed speed based on tests, added text files * Update src/main/java/frc/robot/subsystems/IntakeSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/IntakeSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/Constants.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/IntakeSubsystem.java Co-authored-by: Minh Vu <[email protected]> * fix: constructors changed * fix: changed intake rest speed * fix: changed intake rest speed function * chore: add import * chore: delete logfile * chore: remove uneeded comment, removed logfile * chore: removed logfile * Update src/main/java/frc/robot/RobotContainer.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/RobotContainer.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/IntakeSubsystem.java Co-authored-by: Minh Vu <[email protected]> * chore: formatting --------- Co-authored-by: lpd20 <[email protected]> Co-authored-by: Lance <[email protected]> * fix: overrun and image flip (#19) --------- Co-authored-by: minhd-vu <[email protected]> Co-authored-by: JetBluefan1 <[email protected]> Co-authored-by: lpd20 <[email protected]> Co-authored-by: Lance <[email protected]>
JetBluefan1
added a commit
that referenced
this pull request
Dec 7, 2024
* feat: created pivot subsystem * feat: add pivot subsystem * feat: add pivot commands * fix: formatting * fix: fix fomatting again * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * fix: removed one motor * feat: assigned pivot commands * feat: add auto * Update src/main/java/frc/robot/RobotContainer.java Co-authored-by: Minh Vu <[email protected]> * fix: changed commands to lambdas * fix: updated formatting of commands/constants * fix: updated measurement units * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * fix: updates additional units * fix: more unit related stuff * fix: formatting * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/Constants.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/RobotContainer.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * fix: units * Update src/main/java/frc/robot/Constants.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * fix: changed unit formatting * fix: added imports * chore: formatting * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * fix: got rid of basemagnitude usage * fix: more unit madness * fix: changed command logic, cleaned up code * fix: changed pivot values * chore: formatting * fix: got rid of math.abs * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * fix: changed pivot commands for pid * chore: formatting changes * feat: changed kg values, added encoder measurement to smartdashboard * fix: potential unit conversion issue * fix: lowered pivot speed * fix: pid testing * fix: added namedcommands, changed method structure * chore: formatting, removed test autos * feat: bucket auto * feat: bucket auto * feat: bucket auto (#20) * chore: set line endings * chore: constants fix (#16) * chore: constants fix * Update src/main/java/frc/robot/Constants.java * Update src/main/java/frc/robot/Constants.java * Update src/main/java/frc/robot/Constants.java * fix: chassis matter * fix: loop overrun warning (#17) * fix: loop overrun warning * fix: formatting * feat: intake (#15) * feat: created intake subsystem * feat: added intake commands * fix: updated intake to use units/inline commands * fix: removed motor inversion, removed units for speed * fix: formatting * fix: fixed speed based on tests, added text files * Update src/main/java/frc/robot/subsystems/IntakeSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/IntakeSubsystem.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/Constants.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/IntakeSubsystem.java Co-authored-by: Minh Vu <[email protected]> * fix: constructors changed * fix: changed intake rest speed * fix: changed intake rest speed function * chore: add import * chore: delete logfile * chore: remove uneeded comment, removed logfile * chore: removed logfile * Update src/main/java/frc/robot/RobotContainer.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/RobotContainer.java Co-authored-by: Minh Vu <[email protected]> * Update src/main/java/frc/robot/subsystems/IntakeSubsystem.java Co-authored-by: Minh Vu <[email protected]> * chore: formatting --------- Co-authored-by: lpd20 <[email protected]> Co-authored-by: Lance <[email protected]> * fix: overrun and image flip (#19) --------- Co-authored-by: minhd-vu <[email protected]> Co-authored-by: JetBluefan1 <[email protected]> Co-authored-by: lpd20 <[email protected]> Co-authored-by: Lance <[email protected]> * Update src/main/java/frc/robot/subsystems/PivotSubsystem.java Co-authored-by: Minh Vu <[email protected]> * fix: merge stuff * fix: changed issues introduced by merge * chore: method structural changes * fix: updated autos based on testing * chore: formatting * fix: remove timeout constants --------- Co-authored-by: Minh Vu <[email protected]> Co-authored-by: zabzzz <[email protected]> Co-authored-by: Lucas Nguyen <[email protected]> Co-authored-by: Lubcas <[email protected]> Co-authored-by: JetBluefan1 <[email protected]> Co-authored-by: JetBluefan1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.