TEL-6201 Add new functions for setting and getting dialplan function. #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloeng
requested review from
Elhodred,
baloeng,
minhtuan1407-telnyx and
tajamulTelnyx
dev-ryanc
requested changes
Dec 3, 2024
src/switch_core_state_machine.c
Outdated
| @@ -390,6 +389,15 @@ static void switch_core_standard_on_execute(switch_core_session_t *session) | |||
|
|
|||
| } | |||
|
|
|||
| post_dialplan_execute = switch_channel_get_variable(session->channel, "post_dialplan_execute"); | |||
There was a problem hiding this comment.
What happen when I execute uuid_broadcast, will it call the post dialplan function?
There was a problem hiding this comment.
i think it should, since this happens in _on_execute handler
There was a problem hiding this comment.
Ideally this should only be executed only when processing dialplan commands during ROUTE state. Otherwise CC commands which always call uuid_broadcast will execute the post dialplan commands.
There was a problem hiding this comment.
ok, I think I understand what you mean now.. I moved it to on_routing handler
baloeng
approved these changes
Dec 4, 2024
Elhodred
approved these changes
Dec 4, 2024
minhtuan1407-telnyx
approved these changes
Dec 5, 2024
…caller_extension_insert_application'.
dev-ryanc
reviewed
Dec 9, 2024
dev-ryanc
requested changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dev-ryanc this is a WIP, but please take a look. thanks