Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios : Activer les sondages (#880) #881

Merged
merged 3 commits into from
Oct 11, 2023
Merged

ios : Activer les sondages (#880) #881

merged 3 commits into from
Oct 11, 2023

Conversation

NicolasBuquet
Copy link
Contributor

Fix #880

Simulator Screen Shot - iPhone 14 - 2023-09-22 at 19 20 43

@NicolasBuquet NicolasBuquet added enhancement New feature or request iOS labels Sep 22, 2023
@NicolasBuquet NicolasBuquet linked an issue Sep 22, 2023 that may be closed by this pull request
iOS : Activer les sondages #880
Closed
@NicolasBuquet NicolasBuquet force-pushed the 880-activer-les-sondages-polls branch from cc93bc8 to 907f564 Compare September 22, 2023 17:37
yostyle
yostyle approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste un commentaire à supprimer avant de merge

Riot/Modules/Room/RoomCoordinator.swift Outdated
@@ -479,22 +478,22 @@ final class RoomCoordinator: NSObject, RoomCoordinatorProtocol {

private func startEditPollCoordinator(startEvent: MXEvent? = nil) {
// Tchap: Feature unavailable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove this comment ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@odelcroi odelcroi changed the title Activer les sondages (Polls) (#880) ios : Activer les sondages (Polls) (#880) Oct 3, 2023
@odelcroi odelcroi changed the title ios : Activer les sondages (Polls) (#880) ios : Activer les sondages (#880) Oct 3, 2023
@odelcroi odelcroi mentioned this pull request Oct 3, 2023
Open
yostyle
yostyle requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La couleur du check devrait être le bleu de Tchap
image

@NicolasBuquet
Copy link
Contributor Author

Done.

Screenshot 2023-10-10 at 18 13 56

@NicolasBuquet NicolasBuquet requested a review from yostyle October 10, 2023 16:20
@NicolasBuquet NicolasBuquet merged commit 9eba487 into develop Oct 11, 2023
2 checks passed
@NicolasBuquet NicolasBuquet deleted the 880-activer-les-sondages-polls branch October 11, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostyle yostyle yostyle approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS : Activer les sondages
2 participants
@NicolasBuquet @yostyle