engine: river job queue #4135
Merged
engine: river job queue #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove multiple instances of `sql.DB` and `Connector` usage. - Switch to using `pgxpool` for database connections consistently. - Simplify the shutdown process by ensuring proper resource cleanup. - Implement a new lock querying method for the switchover state. - Delete unused `connector.go` as it is no longer needed.
- Replace manual retry logic with higher-level config setup - Remove custom retry driver and connector implementations - Simplify code by using pgxpool's built-in configuration options
- Implement SWOConnUnlockAll to release all locks - Configure PGX pool to unlock upon release of connections
- Eliminated import of the unused time package. - Removed unnecessary pool configuration for health checks and connection idle time to simplify code.
- Updated to sqlc v1.27.0 - Removed sql-migrate dependency - Enhanced parsing logic for migrations without external library - Adjusted file mode representation to octal style
- Initialize River client and UI server in the app - Add River-related error handling - Update HTTP routing for River UI access - Enhance navigation with a link to the River UI - Create database migrations for River job management
This reverts commit 2b2bf1d.
KatieMSB
previously approved these changes
Nov 11, 2024
m17ch
previously approved these changes
Nov 12, 2024
m17ch
previously approved these changes
Nov 12, 2024
KatieMSB
previously approved these changes
Nov 12, 2024
m17ch
previously approved these changes
Nov 12, 2024
KatieMSB
previously approved these changes
Nov 12, 2024
KatieMSB
approved these changes
Nov 12, 2024
m17ch
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds River job queue
ls-treeinstead ofls-files(the latter will return files on the current branch)