Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine/compatmanager: migrate to sqlc #4104

Merged
merged 7 commits into from
Dec 26, 2024
Merged

Conversation

mastercactapus
Copy link
Member

Description:

  • Migrates the compatmanager to use sqlc
  • No queries were changed other than CompatAuthSubSetCMID, auth_subjects. was added as a prefix to the id in the where clause to fix sqlc complaining about ambiguity.

Out of Scope:

  • This could be switched to use dest instead of type and value in the future

Describe any introduced user-facing changes:
N/A

Describe any introduced API changes:
N/A

@github-actions github-actions bot added the size/m label Oct 9, 2024
KatieMSB
KatieMSB previously approved these changes Oct 11, 2024
ethan-haynes
ethan-haynes previously approved these changes Nov 14, 2024
AlaricWhitney
AlaricWhitney previously approved these changes Nov 26, 2024
@mastercactapus mastercactapus merged commit 91dd701 into master Dec 26, 2024
8 checks passed
@mastercactapus mastercactapus deleted the engine-compat-sqlc branch December 26, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants