aeon: connect implementation

[dmyger]

Mock server Implement some base methods for integration tests.

Part of #1050

[oleg-jukovec]

Do we need to specify a branch here? Or just a commit would be enough.

[oleg-jukovec]

Suggested change

	// Address is a connection Url, unix socket address and etc.
	// Address is a connection URL, unix socket address and etc.

[oleg-jukovec]

Let's not install it automatically. It's better to add requirements here:
https://github.com/tarantool/tt?tab=readme-ov-file#build-from-source

And install it by mage (I'm not sure about the current approach) or on CI manually.

Suggested change

	if [ ! -x "$(command -v protoc-gen-go)" ]; then
	go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
	fi
	if [ ! -x "$(command -v protoc-gen-go-grpc)" ]; then
	go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@latest
	fi
	if [ ! -x "$(command -v protoc-gen-go)" ]; then
	echo "foo"
	exit 1
	fi
	if [ ! -x "$(command -v protoc-gen-go-grpc)" ]; then
	echo "foo"
	exit 1
	fi

it also a good idea to add a target into magefile.go to generate the code or update a some exists target.

Motivation: it's a bad idea to install some software for a user in a background.

[oleg-jukovec]

Suggested change

	### Server .key&.crt and ca.crt required for Server-Side TLS mode.
	### Server .key.crt and ca.crt required for Server-Side TLS mode.

[oleg-jukovec]

Please, avoid an error processing in that manner:

1. It is harder to test.
2. It is harder to understand which parts of the code may result an error.

Suggested change

	func getTlsConfig(args cmd.Ssl) *tls.Config {
	if args.CaFile == "" {
	return &tls.Config{
	ClientAuth: tls.NoClientCert,
	}
	}
	ca, err := os.ReadFile(args.CaFile)
	if err != nil {
	log.Fatalf("Failed to read CA file: %v", err)
	}
	func getTlsConfig(args cmd.Ssl) (*tls.Config, error) {
	if args.CaFile == "" {
	return &tls.Config{
	ClientAuth: tls.NoClientCert,
	}
	}
	ca, err := os.ReadFile(args.CaFile)
	if err != nil {
	fmt.Errorf("Failed to read CA file: %w", err)
	}

[oleg-jukovec]

Please, add tests.

[oleg-jukovec]

Suggested change

	// Handler is a auxiliary abstraction to isolate the console from
	// the implementation of a particular instruction processor.
	type Handler interface {
	// Title return name of instruction processor instance.
	Title() string
	// Validate the input string.
	Validate(input string) bool
	// Complete checks the input and return available variants to continue typing.
	Complete(input prompt.Document) []prompt.Suggest
	// Execute accept input to perform actions defined by client implementation.
	// Expecting that result type implements Formatter interface.
	Execute(input string) any
	// Close notify handler to terminate execution and close any opened streams.
	Close()
	}
	// Handler is a auxiliary abstraction to isolate the console from
	// the implementation of a particular instruction processor.
	type Handler interface {
	// Title return name of instruction processor instance.
	Title() string
	// Validate the input string.
	Validate(input string) bool
	// Complete checks the input and return available variants to continue typing.
	Complete(input prompt.Document) []prompt.Suggest
	// Execute accept input to perform actions defined by client implementation.
	// Expecting that result type implements Formatter interface.
	Execute(input string) any
	// Close notify handler to terminate execution and close any opened streams.
	Close()
	}

[oleg-jukovec]

So why does it return any?

[oleg-jukovec]

Missed comments.

[oleg-jukovec]

And missed tests.

[oleg-jukovec]

Please, add a CHANGELOG.md entry and a TarantoolBot comment too.