Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infrastructure] Update Codecov upload steps #374

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

uilianries
Copy link
Member

The current Codecov is not receiving the Code coverage results anymore, the last report is 3 months old: https://app.codecov.io/gh/taocpp/PEGTL/tree/work

The Codecov changed a bit, now they have an integrated Github Action, that can be connected directly to project: https://github.com/marketplace/actions/codecov

The current upload steps are a bit different, not including the new integrated application, but the token used for upload: https://docs.codecov.com/docs/github-2-getting-a-codecov-account-and-uploading-coverage#install-the-github-app-integration

Signed-off-by: Uilian Ries <[email protected]>
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.63%. Comparing base (3356c1b) to head (499eed0).
Report is 66 commits behind head on work.

Additional details and impacted files
@@            Coverage Diff             @@
##             work     #374      +/-   ##
==========================================
- Coverage   99.27%   97.63%   -1.65%     
==========================================
  Files         362      365       +3     
  Lines        6939     7114     +175     
  Branches        0      202     +202     
==========================================
+ Hits         6889     6946      +57     
  Misses         50       50              
- Partials        0      118     +118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uilianries uilianries marked this pull request as ready for review November 27, 2024 19:39
@uilianries uilianries merged commit 513a4d1 into work Nov 27, 2024
84 of 126 checks passed
@uilianries uilianries deleted the work-fix-coverage branch November 27, 2024 19:39
@uilianries uilianries restored the work-fix-coverage branch November 27, 2024 19:41
@uilianries uilianries deleted the work-fix-coverage branch November 27, 2024 19:41
@d-frey
Copy link
Member

d-frey commented Nov 27, 2024

Thanks for working on this! I tried adding a code coverage job to taocpp/taopq, but it failed. Could you move the token from the PEGTL to the organization level (taocpp)? (Given that this would allow all taocpp-projects to use Codecov)

@uilianries
Copy link
Member Author

@d-frey That's not possible, not because Github does not support (it does: https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secrets-for-an-organization), but because Codecov generates different tokens for each project, as fine grain token, so in case one token is compromised, we don't risk all projects.

I can adjust it right now, but to you understand the steps:

@uilianries
Copy link
Member Author

@d-frey @ColinH The Taopq is working again on the Codecov page: https://app.codecov.io/gh/taocpp/taopq. An incredible coverage of 96.96%!!!

I see other projects are not configured yet, I'll take a look by today during my evening.

@d-frey
Copy link
Member

d-frey commented Nov 28, 2024

Thank you! I will bring the Badge back for the taopq README :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants