Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat use tdigest for metrics #546

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feat use tdigest for metrics #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba7f66d
feat: use tdigest for metrics
nathanielc May 4, 2023
3f10d0d
fix: use digest for scenario and tx metrics
nathanielc May 9, 2023
a8f63b4
fix: remove dead code merge_times
nathanielc May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Cargo.toml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to be able to merge this PR, it will need to be against the latest development version of the codebase. Please rebase. (I understand you desire the use of Gaggles, there is work underway to add them back in 0.18 (more likely to be called 1.0).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase the work doesn't look to be too much work.

Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,18 @@ num_cpus = "1.14"
num-format = "0.4"
rand = "0.8"
regex = "1"
reqwest = { version = "0.11", default-features = false, features = [
reqwest = { version = "0.11", default-features = false, features = [
"cookies",
"gzip",
"json",
] }
serde = { version = "1.0", features = [
"derive",
] }
serde = { version = "1.0", features = ["derive"] }
serde_cbor = "0.11"
serde_json = "1.0"
simplelog = "0.12"
strum = "0.24"
strum_macros = "0.24"
tdigest = { version = "0.2.3", features = ["serde", "use_serde"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this library hasn't been updated in 2 years, is there anything that has replaced it? Does it matter that it's not being updated?
https://github.com/MnO2/t-digest

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, there is another implementation here https://docs.rs/pdatastructs/latest/pdatastructs/tdigest/struct.TDigest.html however that doesn't implement serde serialize/deserialize which we would need.

I am not concerned about the crate not getting updates as this is the kind of things that once implemented correctly doesn't need ongoing maintanence. However if you would prefer I can change out the implementation.

Or as we discussed I could make the implementation generic and then users can bring their own solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, with your effort toward making it Generic, I agree there's no huge risk using the library you have chosen.

tokio = { version = "1.23", features = [
"fs",
"io-util",
Expand Down
Loading