Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement long tuples #590

Merged
merged 14 commits into from
Jul 24, 2024
Merged

Implement long tuples #590

merged 14 commits into from
Jul 24, 2024

Conversation

Gusarich
Copy link
Member

Closes #248

  • I have updated CHANGELOG.md
  • I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich force-pushed the long-tuples branch 2 times, most recently from 8c7c5b3 to 4c0fbed Compare July 21, 2024 12:28
@Gusarich Gusarich added this to the v1.4.1 milestone Jul 21, 2024
@Gusarich Gusarich requested a review from anton-trunov July 21, 2024 12:28
anton-trunov
anton-trunov requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome progress! Just a couple remarks

src/test/e2e-emulated/contracts/structs.tact Outdated Show resolved Hide resolved
src/generator/writers/writeStdlib.ts Outdated Show resolved Hide resolved
@anton-trunov anton-trunov self-assigned this Jul 22, 2024
@Gusarich Gusarich requested a review from anton-trunov July 24, 2024 04:15
@Gusarich Gusarich requested a review from anton-trunov July 24, 2024 06:57
@anton-trunov anton-trunov merged commit f6bec4b into tact-lang:main Jul 24, 2024
3 checks passed
@Gusarich Gusarich mentioned this pull request Aug 9, 2024
Closed
@novusnota novusnota mentioned this pull request Dec 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.4.1
2 participants
@Gusarich @anton-trunov