Draft: pretty-printer tests with random generated AST Expressions #1248
+376
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when I see something like this, I immediately think of adding shrinking (fast-check should support it) even shrinking integer literals would already help a lot here |
I'm thinking about that right now. It might become more user- friendly values value: fc.bigInt({ min: -1_000_000_000n, max: 1_000_000_000n }) |
Comment on lines
59
to
60
| left: expression, | ||
| right: expression, |
There was a problem hiding this comment.
These two need to be different expressions in general
Comment on lines
23
to
24
| id: fc.constant(0), | ||
| loc: fc.constant(dummySrcInfo), |
There was a problem hiding this comment.
I'd add a wrapper to automatically add these id and loc to the generated AST nodes
There was a problem hiding this comment.
All generators wrapped by dummyAstNode now
Comment on lines
68
to
70
| condition: expression, | ||
| thenBranch: expression, | ||
| elseBranch: expression, |
There was a problem hiding this comment.
These need to be 3 different expressions
There was a problem hiding this comment.
Fixed, every expression is new-generated
xpyctumo
force-pushed
the
fast-check
branch
2 times, most recently
from
80ca1e6 to
88786b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Towards #642
Checklist
docs/and made the build locallya--banda++b#1247Plan