Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add VarInt16, VarInt32, VarUint16, VarUint32 Integer Formats and fix coins in foreach #1186

Merged
merged 11 commits into from
Dec 25, 2024
Merged

feat: add VarInt16, VarInt32, VarUint16, VarUint32 Integer Formats and fix coins in foreach #1186

merged 11 commits into from
Dec 25, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Dec 14, 2024 •
edited
Loading

Issue

Closes #1117 and closes #1214.

Checklist

  • I have updated CHANGELOG.md
  • I have documented my contribution in docs/ and made the build locally
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added scope: maps The map datatype and operations on it scope: codegen Code generation, a.k.a. compiler backend labels Dec 14, 2024
@Gusarich Gusarich requested a review from a team as a code owner December 14, 2024 09:05
@Gusarich
Copy link
Member Author

@anton-trunov maps.tact fails during FunC compilation after adding new value formats... we have exceeded the 255 usable stack items limit

fatal: Too deep stack

@anton-trunov anton-trunov self-assigned this Dec 19, 2024
@anton-trunov anton-trunov added this to the v1.6.0 milestone Dec 19, 2024
@anton-trunov
Copy link
Member

there is a merge conflict: src/types/snapshots/resolveDescriptors.spec.ts.snap

@Gusarich Gusarich changed the title feat: VarInt16, VarInt32, VarUint16, VarUint32 Integer Formats feat: add VarInt16, VarInt32, VarUint16, VarUint32 Integer Formats and fix coins in foreach Dec 19, 2024
@Gusarich
Copy link
Member Author

Discovered #1214 while implementing varints support for foreach, fixed that in the same commit

@Gusarich
Copy link
Member Author

also depends on ton-org/ton-core#59

@novusnota
Copy link
Member

I'll write the docs for this soon

@anton-trunov anton-trunov mentioned this pull request Dec 25, 2024
Open
anton-trunov
anton-trunov approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this without the corresponding doc section because it's a blocker on FunC 0.4.6 update

@anton-trunov anton-trunov merged commit 136665e into tact-lang:main Dec 25, 2024
15 checks passed
xpyctumo pushed a commit that referenced this pull request Dec 26, 2024
@Gusarich @xpyctum
feat/fix: add VarInt16, VarInt32, VarUint16, VarUint32 intege…
e58730a 
…r formats and fix `coins` in `foreach` (#1186)

* fix: implement `foreach` for coins and varints

* split map tests into two because we have exceeded the 255 usable stack items limit and started getting the following error `fatal: Too deep stack`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
scope: codegen Code generation, a.k.a. compiler backend scope: maps The map datatype and operations on it
Projects
None yet
Milestone
v1.6.0
3 participants
@Gusarich @anton-trunov @novusnota