add unixsocket without real inode #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ken4647
reviewed
Nov 26, 2024
ken4647
reviewed
Nov 28, 2024
api/ruxos_posix_api/src/imp/net.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub enum Sockaddr { |
There was a problem hiding this comment.
This Sockaddr is an illegal Camel case varibale name, and it should be more distinguishable with existing name SocketAddr。
There was a problem hiding this comment.
I think SockaddrUn is clear enough to represent unix socket address, and i just change it into SockAddrUn
There was a problem hiding this comment.
I think SockaddrUn is clear enough to represent unix socket address, and i just change it into SockAddrUn
Using "SocketAddrUnix" as a variable name is better; Sock is somewhat less intuitive and can easily lead to confusion.
api/ruxos_posix_api/src/imp/net.rs
Outdated
| @@ -208,6 +291,14 @@ impl From<ctypes::sockaddr_in> for SocketAddrV4 { | |||
| } | |||
| } | |||
|
|
|||
| fn un_into_sockaddr(addr: SockaddrUn) -> (ctypes::sockaddr, ctypes::socklen_t) { | |||
| debug!(" Sockaddr: {:?}", addr); | |||
There was a problem hiding this comment.
The debug message should more clear, let it tell about which function it from and other more information.
api/ruxos_posix_api/src/imp/net.rs
Outdated
| size_of::<ctypes::sockaddr>() as _, | ||
| ) | ||
| } | ||
|
|
||
| fn into_sockaddr(addr: SocketAddr) -> (ctypes::sockaddr, ctypes::socklen_t) { | ||
| debug!(" Sockaddr: {}", addr); |
lhw2002426
force-pushed
the
dev
branch
2 times, most recently
from
c295505 to
213d065
Compare
ken4647
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add unix socket ans AF_UNIX type for socket
but not impl SOCK_DGRAM, and use alloced index rather than inode for unixsocket because inode is not impl yet