subdivide blocks if needed in Phase::Relations #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small quality-of-life tweak for people iterating on a theme on a small extract. I often test on a Nova Scotia extract. It's big enough to test many things, but small enough to be fast to process, about 25 seconds. 6 seconds are spent in Phase::Relations processing. The extract has 1,647 blocks, split roughly: - 1,500-ish with nodes - 140-ish with ways - only 3 with relations Thus, most of my CPU cores are idle during Phase::Relations, as there are not enough blocks to go around. This is doubly bad, as a block of relations takes much longer than a block of nodes or ways, due to the more complex geometries involved. This PR changes Tilemaker such that if it sees the relations phase has too few blocks, it artificially subdivides them in order to keep the CPUs busy. This reduces my time for Nova Scotia to about 20 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small quality-of-life tweak for people iterating on a theme on a small extract.
I often test on a Nova Scotia extract. It's big enough to test many things, but small enough to be fast to process, about 25 seconds. 6 seconds are spent in Phase::Relations processing.
The extract has 1,647 blocks, split roughly:
Thus, most of my CPU cores are idle during Phase::Relations, as there are not enough blocks to go around.
This is doubly bad, as a block of relations takes much longer than a block of nodes or ways, due to the more complex geometries involved.
This PR changes Tilemaker such that if it sees the relations phase has too few blocks, it artificially subdivides them in order to keep the CPUs busy.
This reduces my time for Nova Scotia to about 20 seconds.