Feature/update vertx #166
Merged
Feature/update vertx #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/org/swisspush/reststorage/EventBusAdapter.java
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #166 +/- ##
=============================================
- Coverage 62.90% 62.61% -0.30%
Complexity 392 392
=============================================
Files 32 32
Lines 2569 2581 +12
Branches 296 297 +1
=============================================
Hits 1616 1616
- Misses 792 804 +12
Partials 161 161 ☔ View full report in Codecov by Sentry. |
hiddenalpha
reviewed
Jan 4, 2024
There was a problem hiding this comment.
TODO:
dos2unix src/main/java/org/swisspush/reststorage/EventBusAdapter.java
dominik-cnx
reviewed
Jan 5, 2024
| <vertx-redis-client.version>4.3.3</vertx-redis-client.version> | ||
| <slf4j.version>1.7.32</slf4j.version> | ||
| <junit.version>4.13.1</junit.version> | ||
| <vertx.version>4.5.1</vertx.version> |
There was a problem hiding this comment.
Do we plan to also update the version in gateleen and all other friends? Is this basically the first step to generally make the upgrade?
There was a problem hiding this comment.
Yes I am currently working on this. All the friends are prepared (with open PRs).
hiddenalpha
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.