Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDCISA-13736] Fix bad habits in FileSystemStorage. #165

Conversation

hiddenalpha
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (1b13c2f) 63.35% compared to head (4fba5af) 62.90%.

Files Patch % Lines
...a/org/swisspush/reststorage/FileSystemStorage.java 40.81% 23 Missing and 6 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #165      +/-   ##
=============================================
- Coverage      63.35%   62.90%   -0.46%     
  Complexity       392      392              
=============================================
  Files             32       32              
  Lines           2549     2569      +20     
  Branches         293      296       +3     
=============================================
+ Hits            1615     1616       +1     
- Misses           776      792      +16     
- Partials         158      161       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddenalpha hiddenalpha merged commit db495db into swisspost:develop Jan 3, 2024
1 of 3 checks passed
@hiddenalpha hiddenalpha deleted the SDCISA-13736-FixBadHabitsIn-FileSystemStorage branch January 3, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant