feat: add the ability to use our icons from within SCSS #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sk to make icons available in the package for development
🦋 Changeset detectedLatest commit: 2c7ce5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
oliverschuerch
requested review from
alizedebray
and removed request for
gfellerph
|
Related Previews |
gfellerph
approved these changes
Dec 4, 2024
packages/documentation/src/stories/foundations/icons/icon.docs.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/foundations/icons/icon.docs.mdx
Outdated
Show resolved
Hide resolved
gfellerph
requested changes
Dec 4, 2024
packages/icons/src/constants.ts
Outdated
Comment on lines
27
to
31
| return `@container pi ${[min, max].filter(Boolean).join(' and ')} { | ||
| g { | ||
| --pis-${size}: block; | ||
| } | ||
| }`; |
There was a problem hiding this comment.
Can you add a fallback for browsers that don't support container queries?
There was a problem hiding this comment.
Not necessary anymore, because I switched to use media queries. They are working great, and are supported since almost a decade. Please have a look at the tested browsers at the top of this PR.
…th the updated icons form the icons package
….mdx Co-authored-by: Philipp Gfeller <[email protected]>
….mdx Co-authored-by: Philipp Gfeller <[email protected]>
# Conflicts: # packages/documentation/src/stories/foundations/icons/icon.styles.scss
…ix to keep maximum backwards compatibility
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used one icon from the current
PostIconSet (icon: 1000) and one from the newUIIconSet (icon accessibility).Both have been tested with the new
post-iconmixin and thepost-iconweb-component.The icons have been implemented into and were served by the test project itself.
Windows 10
Android
Mac OS
iOS
iPadOS