Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "likes_string" to "likes_catnip" #906

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

kaijagahm
Copy link
Contributor

Closes #901

Changed likes_string variable in the cats data frame to likes_catnip instead. This should clear up a frequent point of confusion where learners interpret "string" as referring to a character data type. See further discussion/description in #901.

Copy link

github-actions bot commented Nov 8, 2024

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@naupaka
Copy link
Member

naupaka commented Nov 8, 2024

Thanks @kaijagahm!

@naupaka naupaka merged commit 5c3da53 into swcarpentry:main Nov 8, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 8, 2024
Auto-generated via `{sandpaper}`
Source  : 5c3da53
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-11-08 18:30:19 +0000
Message : Merge pull request #906 from kaijagahm/fix-likes-string

Change "likes_string" to "likes_catnip"
github-actions bot pushed a commit that referenced this pull request Nov 8, 2024
Auto-generated via `{sandpaper}`
Source  : 7cfe376
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-08 18:31:43 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 5c3da53
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-11-08 18:30:19 +0000
Message : Merge pull request #906 from kaijagahm/fix-likes-string

Change "likes_string" to "likes_catnip"
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
Auto-generated via `{sandpaper}`
Source  : 5c3da53
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-11-08 18:30:19 +0000
Message : Merge pull request #906 from kaijagahm/fix-likes-string

Change "likes_string" to "likes_catnip"
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
Auto-generated via `{sandpaper}`
Source  : d9f777b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-12 00:17:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 5c3da53
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-11-08 18:30:19 +0000
Message : Merge pull request #906 from kaijagahm/fix-likes-string

Change "likes_string" to "likes_catnip"
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
Auto-generated via `{sandpaper}`
Source  : 5c3da53
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-11-08 18:30:19 +0000
Message : Merge pull request #906 from kaijagahm/fix-likes-string

Change "likes_string" to "likes_catnip"
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
Auto-generated via `{sandpaper}`
Source  : 286aa2b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-19 00:21:37 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 5c3da53
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-11-08 18:30:19 +0000
Message : Merge pull request #906 from kaijagahm/fix-likes-string

Change "likes_string" to "likes_catnip"
@kaijagahm kaijagahm deleted the fix-likes-string branch November 22, 2024 04:19
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Auto-generated via `{sandpaper}`
Source  : 5c3da53
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-11-08 18:30:19 +0000
Message : Merge pull request #906 from kaijagahm/fix-likes-string

Change "likes_string" to "likes_catnip"
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Auto-generated via `{sandpaper}`
Source  : b856e59
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-26 00:18:36 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 5c3da53
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-11-08 18:30:19 +0000
Message : Merge pull request #906 from kaijagahm/fix-likes-string

Change "likes_string" to "likes_catnip"
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
Auto-generated via `{sandpaper}`
Source  : b856e59
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-26 00:18:36 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 5c3da53
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-11-08 18:30:19 +0000
Message : Merge pull request #906 from kaijagahm/fix-likes-string

Change "likes_string" to "likes_catnip"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change likes_string to something less confusing
2 participants