-
-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove plyr episode and update episode numbering #885
Remove plyr episode and update episode numbering #885
Conversation
Older version is giving installation errors on macOS.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-885 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-04-11 23:59:45 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @milanmlft for tackling this.
I am happy with removing references to plyr.
@naupaka - can you please have a second look to confirm and merge this as I notice you've had a look at this issue back in 2019-2020?
I agree it's time to get this removed -- I am still wondering if there is a way to archive it or something. @tobyhodges is that something other lessons have done? If not, then I guess it is reasonable just to remove it and the references to it. I think it's reasonable to separate the removal of plyr and the request for a purrr lesson (which are both part of the discussion on #540). |
@naupaka we could archive it e.g. by relocating it to the More dropdown menu: making it somewhat similar to the extra episode available in the DC Image Processing curriculum. What would be the motivation for keeping it, as opposed to removing it from the lesson altogether? My interpretation of the discussion is that Good point about the request for |
I'd suggest creating a new issue for this. Currently this PR is set to close #540 when it gets merged in. |
I've opened the pleasingly-numbered #888 to provide a place for further discussion of the possibility to include an episode about @swcarpentry/r-novice-gapminder-maintainers is this ready to merge, or did you want to request something more from @milanmlft? |
Happy for this to be merged. Thanks @tobyhodges and @milanmlft |
Auto-generated via {sandpaper} Source : 3c63857 Branch : main Author : Sehrish Kanwal <[email protected]> Time : 2024-04-12 01:42:51 +0000 Message : Merge pull request #885 from milanmlft/milanmlft/540-remove-plyr-episode Remove plyr episode and update episode numbering
Auto-generated via {sandpaper} Source : e5c1d03 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-04-12 01:45:31 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 3c63857 Branch : main Author : Sehrish Kanwal <[email protected]> Time : 2024-04-12 01:42:51 +0000 Message : Merge pull request #885 from milanmlft/milanmlft/540-remove-plyr-episode Remove plyr episode and update episode numbering
Wow, end of an era. plyr, we knew ye well. Thanks all! |
Auto-generated via {sandpaper} Source : 3c63857 Branch : main Author : Sehrish Kanwal <[email protected]> Time : 2024-04-12 01:42:51 +0000 Message : Merge pull request #885 from milanmlft/milanmlft/540-remove-plyr-episode Remove plyr episode and update episode numbering
Auto-generated via {sandpaper} Source : b3e4049 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-04-16 00:13:34 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 3c63857 Branch : main Author : Sehrish Kanwal <[email protected]> Time : 2024-04-12 01:42:51 +0000 Message : Merge pull request #885 from milanmlft/milanmlft/540-remove-plyr-episode Remove plyr episode and update episode numbering
Fixes #540
Removes the plyr episode as it has become obsolete and plyr has been retired.
I also updated the version of
igraph
in the package cache, as the older version was giving installation errors when trying to build the lesson locally.