Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscript markup (based on comments by @maneesha and @zkamvar) #874

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

matthieu-bruneaux
Copy link
Contributor

Closes #861.

Fixed the issue with subscript markup noticed by @maneesha using the suggestion from @zkamvar.

Copy link

github-actions bot commented Nov 18, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-874

The following changes were observed in the rendered markdown documents:

 01-rstudio-intro.md  |    2 +-
 02-project-intro.md  |    2 +-
 03-seeking-help.md   |    4 +-
 15-knitr-markdown.md |    2 +-
 config.yaml (gone)   |   96 -----
 md5sum.txt           |   50 +--
 renv.lock (gone)     | 1088 --------------------------------------------------
 7 files changed, 30 insertions(+), 1214 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-18 15:32:52 +0000

github-actions bot pushed a commit that referenced this pull request Nov 18, 2023
@matthieu-bruneaux matthieu-bruneaux merged commit 90ab18e into swcarpentry:main Nov 18, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 18, 2023
Auto-generated via {sandpaper}
Source  : 90ab18e
Branch  : main
Author  : Matthieu Bruneaux <[email protected]>
Time    : 2023-11-18 15:37:57 +0000
Message : Merge pull request #874 from matthieu-bruneaux/main

Fix subscript markup (based on comments by @maneesha and @zkamvar)
github-actions bot pushed a commit that referenced this pull request Nov 18, 2023
Auto-generated via {sandpaper}
Source  : 0277472
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-18 15:39:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 90ab18e
Branch  : main
Author  : Matthieu Bruneaux <[email protected]>
Time    : 2023-11-18 15:37:57 +0000
Message : Merge pull request #874 from matthieu-bruneaux/main

Fix subscript markup (based on comments by @maneesha and @zkamvar)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subscripts are actually strikethroughs
1 participant