Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify motivation section text #857

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Clarify motivation section text #857

merged 2 commits into from
Nov 8, 2023

Conversation

acollens
Copy link
Contributor

Removed excess language and re-ordered paragraphs for clarity. I removed jargon before it was defined (e.g. IDE) and removed repetitive language. I also clarified why R is a useful tool to learn compared to Excel or Sheets.

Removed excess language and re-ordered paragraphs for clarity. I removed jargon before it was defined (e.g. IDE) and removed repetitive language. I also clarified why R is a useful tool to learn compared to Excel or Sheets.
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-857

The following changes were observed in the rendered markdown documents:

 01-rstudio-intro.md | 43 ++++++++++++++++++++++---------------------
 md5sum.txt          |  2 +-
 2 files changed, 23 insertions(+), 22 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-08 23:20:01 +0000

@skanwal skanwal requested review from zkamvar and skanwal November 8, 2023 22:58
Copy link
Contributor

@skanwal skanwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @acollens for the suggested improvements. It reads well to me and make sense too.

@zkamvar - if you have time, can you please review so that we can merge this one?

Copy link
Contributor

@zkamvar zkamvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me. There is only one minor syntax error, but it is not a big deal.

I'm not sure why the checks did not run, but since this is all text annotations, I am confident that it will merge well and run correctly.

episodes/01-rstudio-intro.Rmd Outdated Show resolved Hide resolved
@skanwal
Copy link
Contributor

skanwal commented Nov 8, 2023

@zkamvar - thanks. I have committed the suggested change and also the checks are now running.

github-actions bot pushed a commit that referenced this pull request Nov 8, 2023
@skanwal skanwal merged commit 957945c into swcarpentry:main Nov 8, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 8, 2023
Auto-generated via {sandpaper}
Source  : 957945c
Branch  : main
Author  : Sehrish Kanwal <[email protected]>
Time    : 2023-11-08 23:28:13 +0000
Message : Merge pull request #857 from acollens/main

Clarify motivation section text
github-actions bot pushed a commit that referenced this pull request Nov 8, 2023
Auto-generated via {sandpaper}
Source  : c5c8c71
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-08 23:29:51 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 957945c
Branch  : main
Author  : Sehrish Kanwal <[email protected]>
Time    : 2023-11-08 23:28:13 +0000
Message : Merge pull request #857 from acollens/main

Clarify motivation section text
github-actions bot pushed a commit that referenced this pull request Nov 14, 2023
Auto-generated via {sandpaper}
Source  : c5c8c71
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-08 23:29:51 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 957945c
Branch  : main
Author  : Sehrish Kanwal <[email protected]>
Time    : 2023-11-08 23:28:13 +0000
Message : Merge pull request #857 from acollens/main

Clarify motivation section text
github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
Auto-generated via {sandpaper}
Source  : c5c8c71
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-08 23:29:51 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 957945c
Branch  : main
Author  : Sehrish Kanwal <[email protected]>
Time    : 2023-11-08 23:28:13 +0000
Message : Merge pull request #857 from acollens/main

Clarify motivation section text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants