-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix Windows tests + enable for PRs #9
Conversation
Also, this PR enables running the tests on PR. |
Thanks, I was going to ask that you add this. |
Nope, doesn't fix it. I'll try installing luaFileSystem |
Hmm, |
I'm not that familiar with github's CI. How do I manually rerun a previous workflow? I can see the results in the old actions, but with no failure, there's no "rerun tests" button. |
I'll open another PR that reverts my changes and adds |
Yup, it's a flake 😭 |
I'll try replacing hererocks with hishamhm/gh-actions-luarocks, which has support for Windows. |
3fb3d07
to
f7a90c5
Compare
67b1e5a
to
dc7069d
Compare
285dabf
to
3e8d52c
Compare
I don't get it... Why on earth has it started compaining about the |
1e8985b
to
db67ad0
Compare
Well, luarocks 3.3.0 is the oldest version that works with the GitHub action 😞 |
825a8c2
to
f3a22f7
Compare
@swarn at this point I'm all out of ideas. Also, I'm not 100 % sure if the
|
Current status:
I have the gut feeling it'll be easier to get this working without hererocks. |
Yeah, I'm noticing that hererocks is unmaintained for five years, probably time to switch. I see you have comments on leafo/gh-actions-luarocks#14 last week about build-time paths not found. This is a runtime path error; is it related? This was all working a year ago, I suppose I should have pinned more versions... |
It could be something similar. But I don't think it's those paths I commented on - it's working for other lua versions. And correcting those environment variables didn't help solve my problem. |
Well, thanks for the effort. I'll merge this now. The code hasn't changed in years, so I'm not too worried about skipping Windows tests for the moment. If you don't mind, can I ask: are you using this library for something? Neovim and Roblox seem to be the main use cases. |
No problem 😄
We intend to use it for rocks.nvim, a neovim package manager that uses luarocks. Right now, it has auto-completion for packages to install/prune and it would be nice to make it fuzzy 😅 |
Cool! |
@mrcjkb If you're curious, I got this working. The problem was the compiler. The Adding the MSVC install action fixes it. LuaRocks uses MSVC and the DLLs work fine. I know you added this action, so I'm not sure what else was going on. I'm also not sure what changed between now and last January, when the workflow last ran. Either luarocks or the windows-latest changed in some way. |
Nice! Thanks for the update. Btw, I've added fuzzy autocompletion to rocks.nvim and it works really nicely 😄 |
See #8 (comment).
It appears
busted
2.2.0 doesn't work on Windows.