Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add luarocks-tag-release workflow #12

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented Mar 8, 2024

Closes #11

@mrcjkb mrcjkb force-pushed the luarocks-tag-release branch from 505b255 to fd93d60 Compare March 8, 2024 15:36
@swarn swarn merged commit 3a6620d into swarn:main Mar 8, 2024
17 checks passed
@mrcjkb mrcjkb deleted the luarocks-tag-release branch March 8, 2024 15:58
@mrcjkb
Copy link
Contributor Author

mrcjkb commented Mar 8, 2024

@swarn One thing I forgot to mention: The way I've implemented this workflow, it only triggers if you push a tag, but not if you create a tag via GitHub Releases.

There's a more complicated setup that solves this problem, which we provide a tutorial for.

But I think for your case, this simple approach should suffice 😄.

@swarn
Copy link
Owner

swarn commented Mar 8, 2024

I agree!

Running into a little bug here, I think. I added the release tag, the ran the workflow manually. It uploaded a fzy-lua rock, rather than a fzy rock.

@swarn
Copy link
Owner

swarn commented Mar 8, 2024

Ha, I added a name field, but now it uploads a main-1 rock to luarocks rather than a 1.0.1-1 rock. I'll stop messing with it until you get a change to check it out.

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Mar 8, 2024

Oh yeah, I missed that 😅
I see you've already added the name.

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Mar 8, 2024

Ha, I added a name field, but now it uploads a main-1 rock to luarocks rather than a 1.0.1-1 rock. I'll stop messing with it until you get a change to check it out.

This is probably because you triggered it on the main branch.
If you trigger it on the tag, it should work (but it might use the old workflow file, so it might be best to delete the tag and create a new one).

@swarn
Copy link
Owner

swarn commented Mar 8, 2024

fzy 1.0.2 is live on luarocks and your windows builds should all succeed now. Thanks for the help!

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Mar 8, 2024

Yay 🚀

It's still failing on the windows GitHub runner I'm using, with

fzy_native.obj : error LNK2019: unresolved external symbol has_match referenced in function filter
fzy_native.obj : error LNK2019: unresolved external symbol match referenced in function score
fzy_native.obj : error LNK2019: unresolved external symbol match_positions referenced in function filter
C:\Users\RUNNER~1\AppData\Local\Temp\luarocks_build-fzy-1.0.2-1-4475950\fzy_native.dll : fatal error LNK1120: 3 unresolved externals

🤔 I wonder if that's a 32 bit vs 64 bit issue, since I'm using windows-2019,
or maybe it's missing some build dependencies.

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Mar 8, 2024

Oh, I know what it is.
The luarocks-tag-release action needs a rockspec template in your case.
I will add this in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fzy-lua fails to install on Windows
2 participants