Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updates for release 0.2.0 #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Updates for release 0.2.0 #19

wants to merge 1 commit into from

Conversation

mpkander
Copy link

Tap on "Preview" ⤴

And choose one of the templates:

Copy link
Contributor

@dzmitry-struk-surf dzmitry-struk-surf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plastb1r
Copy link

@mpkander Can we add a couple more exceptions?
Propose this list:

prefer-widget-private-members: false
Many of flutter widgets themselves use public fields and methods that can be used elsewhere to read configuration, retrieving them by context. I agree that, like any public entity, their use should be limited, but they should not be banned.

prefer-correct-error-name: false
There is another lint that advises prescribing the type of what we are trying to intercept. For example, "on Exception". And therefore, it seems redundant to prescribe the name of the variable.

avoid-empty-setstate: false
There is a practice of using setState when it is called empty at the end of the callback, when manipulations to change the state have already been performed in front of it, to decrease nesting of setState.

no-empty-block: false
Sometimes its more convenient to pass an empty callback for not making a field nullable.

Also, we can expand prefer-correct-identifier-length exceptions with 'n', 'e', 'x', 'y', 'z' for indexing, exceptions and pixels/planes working, respectively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants