Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: crash on android 14 #72

Merged
merged 2 commits into from
Dec 21, 2023
Merged

[FIX]: crash on android 14 #72

merged 2 commits into from
Dec 21, 2023

Conversation

GalimzyanovDanil
Copy link
Contributor

@GalimzyanovDanil GalimzyanovDanil commented Dec 21, 2023

Changes

Check if the device's Android version is Oreo or higher. If Oreo or higher, register the broadcast receiver with additional parameters to request permission for sending SMS. If below Oreo, register the broadcast receiver with basic parameters (without permission request).

Troubles (optional)

Closes: #70

Note (optional)

Checklist for self-check

  • Commits and PRs have been filed according to the rules on the project.
  • The author is marked as an assigne and assigned mandatory reviewers.
  • Required labels marked
  • Specified related tasks and/or related PRs.
  • Specified Changes.
  • Attached videos/screenshots demonstrating the fix/feature.
  • All unspecified fields in the PR description deleted.
  • New code covered by tests.

Checklist for reviewers

  • CI passed successfully (with a green check mark).
  • PR is atomic, by volume no more than 400 (+-) corrected lines (not including codogen).

Design:

  • System design corresponds to the agreements on structure and architecture on the project.
  • The code is decomposed into necessary and sufficient components.

Functionality:

  • The code solves the problem.
  • Any changes to the user interface are reasonable and look good.

Complexity:

  • The code is clear, easy to read, functions are small, no more than 50 lines.
  • The logic is not overcomplicated, there is no overengineering (no code sections that may be needed in the future, but no one knows about it).

Tests:

  • Updated or added tests for mandatory components.
  • The tests are correct, helpful, and well designed/developed.

Naming:

  • The naming of variables, methods, classes and other components is understandable.

Comments:

  • The comments are understandable and helpful.

Documentation:

  • All labels are correct
  • Technical documentation updated (after approval, updates last reviewer).

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d152e6) 96.34% compared to head (899b0d4) 96.34%.

❗ Current head 899b0d4 differs from pull request most recent head f243355. Consider uploading reports for the commit f243355 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files           4        4           
  Lines          82       82           
=======================================
  Hits           79       79           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-sysoev maxim-sysoev merged commit c0b6974 into main Dec 21, 2023
16 checks passed
@maxim-sysoev maxim-sysoev deleted the fix-android-14 branch December 21, 2023 08:04
This was referenced Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Android 14 SecurityException Specify RECEIVER_EXPORTED
4 participants