-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Refactor CSS, split into files, update templates #3519
Open
f0x52
wants to merge
11
commits into
main
Choose a base branch
from
frontend-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0x52
added
frontend
Frontend-related stuff
chore
a pain in the butt that needs doing
labels
Nov 6, 2024
Hell yeah nice one!!! Will get this reviewed! |
I finally had a look through and it looks good to me! With the different indentation now used in the HTML you'll have to change the four spaces here to a tab instead: gotosocial/internal/router/template.go Line 296 in 3015436
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bit of a hellish PR, with the frontend refactor I started with over the summer. Checked pretty much everything on the testrig for correctness, only thing I didn't was themes.
Includes new set of eslint rules which mesh with typescript, but have every rule set to warn instead of error with a plugin, to be followed up with a separate PR that includes lots of linting fixes.
Checklist
go fmt ./...
andgolangci-lint run
.