Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Refactor CSS, split into files, update templates #3519

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Nov 6, 2024

Description

Bit of a hellish PR, with the frontend refactor I started with over the summer. Checked pretty much everything on the testrig for correctness, only thing I didn't was themes.
Includes new set of eslint rules which mesh with typescript, but have every rule set to warn instead of error with a plugin, to be followed up with a separate PR that includes lots of linting fixes.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@f0x52 f0x52 added frontend Frontend-related stuff chore a pain in the butt that needs doing labels Nov 6, 2024
@f0x52 f0x52 requested a review from tsmethurst November 6, 2024 13:30
@tsmethurst
Copy link
Contributor

Hell yeah nice one!!! Will get this reviewed!

@tsmethurst
Copy link
Contributor

I finally had a look through and it looks good to me! With the different indentation now used in the HTML you'll have to change the four spaces here to a tab instead:

indentStr = " "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a pain in the butt that needs doing frontend Frontend-related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants