Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the ordering to contain more variables than the input polynomials #165

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

sumiya11
Copy link
Owner

@sumiya11 sumiya11 commented Nov 23, 2024

With this PR, the following does not error:

using DynamicPolynomials, Groebner
@polyvar x y z
groebner([x, y], ordering=Lex(x, y, z))

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.27%. Comparing base (ff30fd1) to head (58ec3bc).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/monomials/orderings.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   94.29%   94.27%   -0.02%     
==========================================
  Files          41       41              
  Lines        5692     5695       +3     
==========================================
+ Hits         5367     5369       +2     
- Misses        325      326       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sumiya11 sumiya11 merged commit 26668d4 into master Nov 23, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant