Add new work source field for ORCID harvesting #1455
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
changed the title
peetucket
force-pushed
the
harvest-from-orcid
branch
from
3d3ee38 to
80cc94f
Compare
peetucket
changed the title
peetucket
force-pushed
the
harvest-from-orcid
branch
from
80cc94f to
0435b05
Compare
peetucket
commented
Mar 18, 2022
| @@ -38,7 +38,8 @@ def map | |||
| conference: map_conference, | |||
| series: map_series, | |||
| pages: work.pages, | |||
| publisher: work.publisher | |||
| publisher: work.publisher, | |||
| orcid_work_source: work.work_source | |||
| }.compact | |||
There was a problem hiding this comment.
this is the new pub_hash field we are mapping to
peetucket
commented
Mar 18, 2022
| def work_source | ||
| @work_source ||= work_response.dig('source', 'source-name', 'value') | ||
| end | ||
|
|
||
| def work_type |
There was a problem hiding this comment.
this is the work response from ORCID we pull the new value from
peetucket
changed the title
peetucket
force-pushed
the
harvest-from-orcid
branch
from
4676a50 to
72b6800
Compare
peetucket
force-pushed
the
harvest-from-orcid
branch
from
72b6800 to
8e5e966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
When we turn on the code to harvest works from ORCID, we may need to add an additional field to the pub hash to show the original source of the work that came from ORCID (e.g. it came to ORCID via CrossRef, we record "CrossRef"). This data is useful for Profiles to show to users.
This is not a hard requirement yet, just did some research and got started on the work.
This assumes the new pub_hash field to be added will be called
orcid_work_source-- need to coordinate with the Profiles team on this.We also need to look at #1456 once we start harvesting from ORCID.
How was this change tested?
Updated tests
Which documentation and/or configurations were updated?