Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle non-requestable items #2038

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Mar 8, 2024

Screenshot 2024-03-08 at 12 27 50

Part of #2006.

@cbeer cbeer force-pushed the non-requestable-items branch from 882a8f0 to 1382929 Compare March 8, 2024 20:27
@cbeer cbeer force-pushed the non-requestable-items branch from 1382929 to bf67ca2 Compare March 8, 2024 20:49
@cbeer cbeer marked this pull request as ready for review March 8, 2024 21:01
@@ -193,4 +193,8 @@ class HoneyPotFieldError < StandardError
def item_not_found(exception)
raise ActiveRecord::RecordNotFound, exception
end

def item_not_requestable
render 'item_not_requestable', status: :bad_request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad_request indeed!

@jcoyne jcoyne merged commit 73e101a into main Mar 8, 2024
2 checks passed
@jcoyne jcoyne deleted the non-requestable-items branch March 8, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants