Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feedback form #69

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[WIP] Feedback form #69

wants to merge 3 commits into from

Conversation

mejackreed
Copy link
Contributor

@mejackreed mejackreed commented Sep 15, 2017

Closes #41

feedback-form

Button stylin' dependent on #66

Copy link

@drh-stanford drh-stanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple clarification questions.

@mailer_parser = FeedbackMailerParser.new(params, ip)

mail(to: Settings.EMAIL_TO.FEEDBACK,
subject: 'Feedback from SearchWorks',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "Bento" or something rather than SearchWorks?


mail(to: Settings.EMAIL_TO.FEEDBACK,
subject: 'Feedback from SearchWorks',
from: '[email protected]',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here -- bento something rather than searchworks.stanford.edu?

@jkeck
Copy link
Contributor

jkeck commented Sep 19, 2017

Per convo in the courtyard, we might want to hold off on this to see how this might be affected by being proxied under library.stanford.edu

@drh-stanford
Copy link

Ok, I'll mark this as WIP

@drh-stanford drh-stanford changed the title Feedback form [WIP] Feedback form Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants