Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to URIs when the file extension is missing. #258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Sep 22, 2017

Stacks used to allow requesting images without an extension. However
this was different than how requests for media or file downloads worked.
Now we prefer the full file name for consistency across all endpoints.

Fixes #193

@coveralls
Copy link

coveralls commented Sep 22, 2017

Coverage Status

Coverage increased (+0.03%) to 96.788% when pulling 50038cc on redirect_extension into bab066a on master.

@mejackreed
Copy link
Contributor

As a preference, I prefer the no-extension approach (maybe I'm alone in that)

@jcoyne jcoyne force-pushed the redirect_extension branch from 50038cc to 4c601e0 Compare October 5, 2017 02:14
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 95.937% when pulling 4c601e0 on redirect_extension into 00f2095 on master.

Stacks used to allow requesting images without an extension. However
this was different than how requests for media or file downloads worked.
Now we prefer the full file name for consistency across all endpoints.

Fixes #193
@jcoyne jcoyne force-pushed the redirect_extension branch from 4c601e0 to 52dd42b Compare October 5, 2017 02:25
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.84% when pulling 52dd42b on redirect_extension into 00f2095 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants