Add ItemDisplay class to contain logic to create item_display values; related cleanup. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylown
commented
Sep 22, 2022
| end | ||
|
|
||
| current_location = holding.current_location | ||
| current_location = 'ON-ORDER' if holding.is_on_order? && holding.current_location && !holding.current_location.empty? && holding.home_location != 'ON-ORDER' && holding.home_location != 'INPROCESS' |
There was a problem hiding this comment.
I'm pretty sure this will never get set because holding.is_on_order? only evaluates to true if holding.current_location is already set to ON-ORDER OR if holding.home_location is ON-ORDER in which case the latter holding.home_location != 'ON-ORDER' condition will not pass. 😕 So I've skipped re-implementing this in ItemDisplay.
corylown
force-pushed
the
item-display
branch
2 times, most recently
from
9a58c8b to
f3e47d1
Compare
corylown
force-pushed
the
item-display
branch
from
f3e47d1 to
fd904f2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I finally have this in shape for a review. Aside from the tests I added, I also tested this on relatively large batches of SUL MARC records both to ensure the code is guarding against any edge cases and for parity in the field values produced for
item_display,shelfkey, andreverse_shelfkey. The only difference is the reverse shelf key now includes the ellipses that get added inItemDisplay. This change is reflected in the rspec tests and I think is fine or an improvement 🤷 .closes #714