Remove extraneous code #1439
Open
Remove extraneous code #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
A /thumb node will always exist in the XML if a suitable thumb is available. There is no need for this fallback, this was duplicating the behavior of the ThumbnailService in DSA
jcoyne
force-pushed
the
remove-unnecessary-thumb
branch
from
4ad160a to
cc13e6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A /thumb node will always exist in the XML if a suitable thumb is available. There is no need for this fallback, this was duplicating the behavior of the ThumbnailService in purl-fetcher